options: Allow OptionsImpl to be constructed from a vector #9147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives better type safety, and is no less efficient since the overload of TCLAP::CmdLine::parse that takes in argc and argv performs the same copy into a std::vector internally. Adding this constructor just gives more flexibility to creators of OptionsImpl instances. Signed-off-by: Alex Konradi <akonradi@google.com>
|
/azp run envoy-linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks. I re-started the tests since the tsan failure is a known flake. Otherwise, looks good. |
zuercher
reviewed
Nov 27, 2019
camelCase, not PascalCase Signed-off-by: Alex Konradi <akonradi@google.com>
yanavlasov
requested changes
Nov 27, 2019
Don't rely on the implementation of the argv/argn constructor on top of the constructor that takes a vector. Have explicit tests of both, and validate the usage of argn to limit the number of elements of argv that are parsed. Signed-off-by: Alex Konradi <akonradi@google.com>
yanavlasov
previously approved these changes
Nov 27, 2019
zuercher
reviewed
Nov 27, 2019
Signed-off-by: Alex Konradi <akonradi@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives better type safety, and is no less efficient since the
overload of TCLAP::CmdLine::parse that takes in argc and argv performs
the same copy into a std::vector internally. Adding this constructor
gives more flexibility to creators of OptionsImpl instances.
Risk Level: low
Testing: ran unit tests
Docs Changes: n/a
Release Notes: n/a