-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: runfiles path fixups to support site specific (e.g. google) imp… #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort. * Access source files via {{ test_srcdir }} everywhere. * Define TEST_RUNDIR, use it to access source files in shell scripts, instead of futzing with $TEST_SRCDIR/$TEST_WORKSPACE. * Wrap sh_test/cc_tests with sh_test_wrapper.sh and provide the ability to override main for C++ tests. This allows site specific customizations to the environment, e.g. overriding TEST_RUNDIR. * Allow TestEnvironment::exec to support Python execution via symlinks. * Some documentation in STYLE.md to capture the conventions. * Fix a port dependency in admin_test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, tiny nit
test/run_envoy_tests.sh
Outdated
@@ -1,6 +1,7 @@ | |||
#!/bin/bash | |||
|
|||
set -e | |||
set -x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
del
mattklein123
approved these changes
Apr 24, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: these translations were graciously written by @XAntonioLuna @sgenius and @gonzalolarralde and published in Lyft Engineering en Español Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: these translations were graciously written by @XAntonioLuna @sgenius and @gonzalolarralde and published in Lyft Engineering en Español Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ort.
Access source files via {{ test_rundir }} everywhere.
Define TEST_RUNDIR, use it to access source files in shell scripts, instead of futzing with
$TEST_SRCDIR/$TEST_WORKSPACE.
Wrap sh_test/cc_tests with sh_test_wrapper.sh and provide the ability to override main for C++
tests. This allows site specific customizations to the environment, e.g. overriding TEST_RUNDIR.
Allow TestEnvironment::exec to support Python execution via symlinks.
Some documentation in STYLE.md to capture the conventions.
Fix a port dependency in admin_test.