Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: templates for e-mails and CVE GH filing. #6442

Merged
merged 3 commits into from
Apr 2, 2019

Conversation

htuch
Copy link
Member

@htuch htuch commented Mar 31, 2019

These capture some of our existing patterns in CVE related e-mail announcements, as well as some
future planned e-mails and GH filing. They are based on OpenSSL security release announcement and
https://github.com/kubernetes/security/blob/master/email-templates.md#security-fix-announcement.

Signed-off-by: Harvey Tuch htuch@google.com

These capture some of our existing patterns in CVE related e-mail announcements, as well as some
future planned e-mails and GH filing. They are based on OpenSSL security release announcement and
https://github.com/kubernetes/security/blob/master/email-templates.md#security-fix-announcement.

Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch
Copy link
Member Author

htuch commented Mar 31, 2019

@duderino @destijl @liggitt would be great to get your thoughts on this. We'd like to have good alignment with k8s and Istio when it comes to messaging formats and details on security issues.

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is super awesome. A few comments from me. Agreed would love to hear from folks more experienced in this process for further comments.

security/email-templates.md Outdated Show resolved Hide resolved
security/email-templates.md Outdated Show resolved Hide resolved
security/email-templates.md Show resolved Hide resolved
Signed-off-by: Harvey Tuch <htuch@google.com>
@mattklein123 mattklein123 self-assigned this Apr 1, 2019
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank's so much. Definitely would love to hear from others but we can always ship and iterate if that is easier.

@liggitt
Copy link

liggitt commented Apr 1, 2019

looks good as a starting point, I'm sure you'll find things you want to tweak.

One thing we've found is that it's helpful to keep emails succinct and link to things that can be edited/updated to incorporate more details post-disclosure. That's especially true for intricate commands or mitigation steps.

@destijl
Copy link

destijl commented Apr 1, 2019

Yep, these look good. Posts to public mailing lists that have stable identifiers are very useful for your distributors, e.g. GKE has a security bulletins page that references K8s announcements via the groups.google.com URL, see https://cloud.google.com/kubernetes-engine/docs/security-bulletins#march-01-2019. Another option, but more work, would be to stand up a similar security bulletins page for Envoy itself (we haven't done this for K8s, yet).

@htuch
Copy link
Member Author

htuch commented Apr 2, 2019

@liggitt @destijl Ack. Our public lists are on googlegroups.com and we also have GH issue URLs as stable IDs. I'm going to merge this and we can continue to iterate as we prepare out current CVE comms.

@htuch htuch merged commit 7b82c0f into envoyproxy:master Apr 2, 2019
@htuch htuch deleted the sec-templates branch April 2, 2019 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants