http2: shard http2 codec_impl_test #5341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test takes forever to run but the test cases are trivially parallelizable. With multiple cores, this reduces the running time significantly. Signed-off-by: Alex Konradi <akonradi@google.com>
alyssawilk
reviewed
Dec 18, 2018
There was a problem hiding this comment.
+1 for sharding. Well honestly I'd prefer fewer combinations and permutations but I recall that getting push going from 1 to 50 seems a bit high - we have other fairly long running tests. Maybe just start with a few shards for first? What are you seeing for timing?
|
Bazel uses 11 cores on my machine; under TSAN this takes 25 seconds sharded, 96 seconds unsharded (when the target is already built). With the regular build it takes 8 seconds sharded and 18 seconds unsharded. The motivation here is mostly to split up the target during execution since it uses way too much memory for our internal TSAN builds. |
Too many shards causes slowdowns for single-core machines. Decrease the shard count to keep this from being an issue for CI. Signed-off-by: Alex Konradi <akonradi@google.com>
alyssawilk
approved these changes
Dec 18, 2018
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
This test takes forever to run but the test cases are trivially parallelizable. With multiple cores, this reduces the running time significantly. Signed-off-by: Alex Konradi <akonradi@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test takes forever to run but the test cases are trivially parallelizable. With multiple cores, this reduces the running time significantly.
Risk Level: low
Testing: ran affected test
Docs Changes: n/a
Release Notes: n/a