test: run main_common_test with IPv4 and v6 #4365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an '{{ ip_any_address }}' replacement pattern and uses that to
interpolate the correct (IPv4 vs IPv6) IP address into the config.
Signed-off-by: Alex Konradi <akonradi@google.com>
Now that the config has been templatized, run the test for both versions, injecting the right address format for each. Signed-off-by: Alex Konradi <akonradi@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Parameterize main_common_test over IPv4 and v6.
Risk Level: Low
Testing: ran affected test locally
Docs Changes: n/a
Release Notes: n/a
Fixes #2649