Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in tcp_proxy #4323

Merged
merged 9 commits into from
Sep 5, 2018
Merged

Fix crash in tcp_proxy #4323

merged 9 commits into from
Sep 5, 2018

Commits on Aug 31, 2018

  1. Fix crash in tcp_proxy. 

    Closing the upstream connection is not safe from the Filter destructor,
because it triggers events back into the downstream connection, which
is partially destructed.

Ensure that the upstream connection is closed before the destructor is called.

Fixes envoyproxy#4310

Signed-off-by: Greg Greenway <ggreenway@apple.com>
    @ggreenway
    ggreenway committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    b64f67c View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2018

  1. Merge remote-tracking branch 'upstream/master' into fix-tcp-proxy-crash

    @ggreenway
    ggreenway committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    58abef0 View commit details
    Browse the repository at this point in the history

  2. fix tests 

    Signed-off-by: Greg Greenway <ggreenway@apple.com>
    @ggreenway
    ggreenway committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    a02bc7e View commit details
    Browse the repository at this point in the history

  3. fix_format 

    Signed-off-by: Greg Greenway <ggreenway@apple.com>
    @ggreenway
    ggreenway committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    ddf1476 View commit details
    Browse the repository at this point in the history

  4. revert no longer needed change 

    Signed-off-by: Greg Greenway <ggreenway@apple.com>
    @ggreenway
    ggreenway committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    5aad056 View commit details
    Browse the repository at this point in the history

  5. Add test that covers new code 

    Signed-off-by: Greg Greenway <ggreenway@apple.com>
    @ggreenway
    ggreenway committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    7e2361c View commit details
    Browse the repository at this point in the history

  6. fix build 

    Signed-off-by: Greg Greenway <ggreenway@apple.com>
    @ggreenway
    ggreenway committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    756d2ac View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2018

  1. fix tsan error in test (use after free) 

    Signed-off-by: Greg Greenway <ggreenway@apple.com>
    @ggreenway
    ggreenway committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    f2b3fbf View commit details
    Browse the repository at this point in the history

  2. Revert tcp_proxy_integration_test fixes. These changes can't be made 

    until behavior changes to tcp_proxy are made.

Signed-off-by: Greg Greenway <ggreenway@apple.com>
    @ggreenway
    ggreenway committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    5fab628 View commit details
    Browse the repository at this point in the history