-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quic: Adding QUIC listener option to reject new connections #36070
Conversation
Signed-off-by: Ricardo Perez <ripere@google.com>
Hi @Rickyp, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
/assign @RyanTheOptimist |
Rickyp is not allowed to assign users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Please also update the changelog to reflect this new API.
Also, the PR description should probably start with "quic: " as per the guidance in https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md#submitting-a-pr |
Please update the PR description to reflect the changlog changes, once complete. |
Signed-off-by: Ricardo Perez <ripere@google.com>
Signed-off-by: Ricardo Perez <ripere@google.com>
Signed-off-by: Ricardo Perez <ripere@google.com>
Signed-off-by: Ricardo Perez <ripere@google.com>
Signed-off-by: Ricardo Perez <ripere@google.com>
Signed-off-by: Ricardo Perez <ripere@google.com>
/lgtm api |
Signed-off-by: Ricardo Perez <ripere@google.com>
Commit Message: Implementing reject_new_connections QUIC listener option.
Additional Description: The goal is to implement a mechanism to configure the bootstrap to reject H3 traffic as early as possible in the QUIC layer. This is done by replying to the client with an empty QUIC version negotiation packet to leverage the incompatible version negotiation logic from RFC 9368. This feature is off by default.
Risk Level: Low
Testing: UTs
Docs Changes: N/A
Release Notes: added new_features/quic note