Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic: Adding QUIC listener option to reject new connections #36070

Merged
merged 8 commits into from
Sep 17, 2024

Conversation

Rickyp
Copy link
Contributor

@Rickyp Rickyp commented Sep 11, 2024

Commit Message: Implementing reject_new_connections QUIC listener option.
Additional Description: The goal is to implement a mechanism to configure the bootstrap to reject H3 traffic as early as possible in the QUIC layer. This is done by replying to the client with an empty QUIC version negotiation packet to leverage the incompatible version negotiation logic from RFC 9368. This feature is off by default.
Risk Level: Low
Testing: UTs
Docs Changes: N/A
Release Notes: added new_features/quic note

Signed-off-by: Ricardo Perez <ripere@google.com>
Copy link

Hi @Rickyp, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #36070 was opened by Rickyp.

see: more, trace.

Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #36070 was opened by Rickyp.

see: more, trace.

@Rickyp
Copy link
Contributor Author

Rickyp commented Sep 11, 2024

/assign @RyanTheOptimist

Copy link

Rickyp is not allowed to assign users.

🐱

Caused by: a #36070 (comment) was created by @Rickyp.

see: more, trace.

Copy link
Contributor

@RyanTheOptimist RyanTheOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Please also update the changelog to reflect this new API.

@RyanTheOptimist
Copy link
Contributor

Also, the PR description should probably start with "quic: " as per the guidance in https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md#submitting-a-pr

@RyanTheOptimist
Copy link
Contributor

Commit Message: Implementing reject_new_connections QUIC listener option. Additional Description: The goal is to implement a mechanism to configure the bootstrap to reject H3 traffic as early as possible in the QUIC layer. This is done by replying to the client with an empty QUIC version negotiation packet to leverage the incompatible version negotiation logic from RFC 9368. This feature is off by default. Risk Level: Low Testing: UTs Docs Changes: N/A Release Notes: N/A

Please update the PR description to reflect the changlog changes, once complete.

Signed-off-by: Ricardo Perez <ripere@google.com>
@Rickyp Rickyp changed the title Adding QUIC listener option to reject new connections quic: Adding QUIC listener option to reject new connections Sep 11, 2024
Signed-off-by: Ricardo Perez <ripere@google.com>
Signed-off-by: Ricardo Perez <ripere@google.com>
Signed-off-by: Ricardo Perez <ripere@google.com>
Signed-off-by: Ricardo Perez <ripere@google.com>
Signed-off-by: Ricardo Perez <ripere@google.com>
@markdroth
Copy link
Contributor

/lgtm api

Signed-off-by: Ricardo Perez <ripere@google.com>
@RyanTheOptimist RyanTheOptimist enabled auto-merge (squash) September 16, 2024 15:29
@RyanTheOptimist RyanTheOptimist merged commit 88543c9 into envoyproxy:main Sep 17, 2024
40 of 41 checks passed
@Rickyp Rickyp deleted the quic_reject_traffic branch September 25, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants