Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ext_proc: observability mode part 4: add deferred closure timeout config #34971

Merged
merged 5 commits into from
Jul 6, 2024
Merged

ext_proc: observability mode part 4: add deferred closure timeout config #34971

merged 5 commits into from
Jul 6, 2024

Conversation

tyxia
Copy link
Member

@tyxia tyxia commented Jun 28, 2024 •
edited
Loading

The default timeout value is chosen same as drain timeout <envoy_v3_api_field_extensions.filters.network.http_connection_manager.v3.HttpConnectionManager.drain_timeout>

@repokitteh-read-only RepoKitteh - Read Only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #34971 was opened by tyxia.

see: more, trace.

@repokitteh-read-only RepoKitteh - Read Only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @mattklein123
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #34971 was opened by tyxia.

see: more, trace.

@tyxia
typo
dea9336 
Signed-off-by: tyxia <tyxia@google.com>
@tyxia
typo
ac3da76 
Signed-off-by: tyxia <tyxia@google.com>
@tyxia tyxia marked this pull request as ready for review June 28, 2024 16:22
@tyxia
Copy link
Member Author

tyxia commented Jun 28, 2024 •
edited
Loading

/assign @yanavlasov

Edit: Yan will be OOO throughout the week, so removed the assignment.

@tyxia tyxia assigned htuch and unassigned yanavlasov Jun 30, 2024
@tyxia
update
3691819 
Signed-off-by: tyxia <tyxia@google.com>
htuch
htuch previously approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge unless @mattklein123 has any objections.

@repokitteh-read-only repokitteh-read-only bot removed the api label Jul 4, 2024
@tyxia
gRPC
bc7badc 
Signed-off-by: tyxia <tyxia@google.com>
@repokitteh-read-only repokitteh-read-only bot removed the api label Jul 6, 2024
@tyxia tyxia merged commit caaafa1 into envoyproxy:main Jul 6, 2024
53 checks passed
@tyxia tyxia deleted the on_timeout branch July 6, 2024 02:51
@tyxia tyxia mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

@htuch htuch htuch left review comments

Assignees

@mattklein123 mattklein123

@htuch htuch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tyxia @mattklein123 @htuch @yanavlasov