routing: allow generating session cookies #3462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables configuring Envoy to generate cookies that expire at the end of a session instead of requiring them to have an explicit max-age. Signed-off-by: Alex Konradi <akonradi@google.com>
akonradi
force-pushed
the
generate-session-cookie
branch
from
48a711c
to
6d0ec4c
Compare
htuch
reviewed
May 22, 2018
| set_cookies.insert(value); | ||
| EXPECT_THAT(value, MatchesRegex("^foo=.*$")); | ||
| }); | ||
| EXPECT_EQ(set_cookies.size(), 1); |
There was a problem hiding this comment.
Do you want this to be a vector (or multiset) so you can validate the cardinality matches the number of requests?
There was a problem hiding this comment.
I could change it to a std::map<string, size_t> and increment the count for the key, but the sendMultipleRequests helper already EXPECTs that each request is completed and calls this callback for each one.
There was a problem hiding this comment.
True, I think this comment can be ignored. Ready to merge.
htuch
previously approved these changes
May 22, 2018
mattklein123
previously approved these changes
May 22, 2018
source/common/router/config_impl.cc
Outdated
| ttl = std::chrono::seconds(hash_policy.cookie().ttl().seconds()); | ||
| } | ||
| hash_impls_.emplace_back(new CookieHashMethod(hash_policy.cookie().name(), ttl)); | ||
| } break; |
There was a problem hiding this comment.
super nit: Can you put the break inside the '}' as is done elsewhere. I wish clang-format fixed this.
Signed-off-by: Alex Konradi <akonradi@google.com>
htuch
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables configuring Envoy to generate cookies that expire at the
end of a session instead of requiring them to have an explicit max-age.
Risk Level: Low
Testing: added unit tests and an integration test
Docs Changes: documented new behavior in API and release docs
Release Notes: router: allow cookie routing to generate session cookies.