Curl buildifier binary instead of installing go 1.8 #3234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Buckland <jbuckland@google.com>
htuch
approved these changes
Apr 26, 2018
mattklein123
approved these changes
Apr 26, 2018
ramaraochavali
pushed a commit
to ramaraochavali/envoy
that referenced
this pull request
May 3, 2018
Signed-off-by: James Buckland <jbuckland@google.com> Signed-off-by: Rama <rama.rao@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James Buckland jbuckland@google.com
title: Curl buildifier binary instead of installing go 1.8
Description:
Addressing #3177, we now no longer need to rely on a local go installation, instead curling the binary from github and placing it in
/usr/local/bin.Risk Level: Medium
Testing:
Fixes issue #3177