Creating a no exceptions build for Envoy Mobile. #29840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssawilk
force-pushed
the
no_exceptions_build
branch
7 times, most recently
from
1412fbd
to
ab7c117
Compare
alyssawilk
force-pushed
the
no_exceptions_build
branch
2 times, most recently
from
5d7f22b
to
4ab63d8
Compare
alyssawilk
force-pushed
the
no_exceptions_build
branch
10 times, most recently
from
63ffdc1
to
6021f9b
Compare
The initial passes of this were over 100 files of workarounds to build bazel build --config=remote --define=admin_html=disabled --define=admin_functionality=disabled --define envoy_exceptions=disabled --define envoy_mobile_listener=disabled --define=envoy_yaml=disabled //test/performance:test_binary_size --copt=-fno-unwind-tables --copt=-fno-exceptions Now we're in the low 70 files, but there's still work todo (see TODO). Landing now as E-M already panics on bad config, and we want to see what the binary size impact is for our E-M usage. Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
force-pushed
the
no_exceptions_build
branch
from
6021f9b
to
c31be28
Compare
alyssawilk
requested review from
KBaichoo,
mattklein123,
yanavlasov and
lizan
as code owners
RyanTheOptimist
approved these changes
Oct 16, 2023
| #ifdef ENVOY_DISABLE_EXCEPTIONS | ||
| PANIC(error); | ||
| #else | ||
| throw SocketBindException(error, result.errno_); |
There was a problem hiding this comment.
This can't use throwExceptionOrPanic() because this exception type's constructor is special?
There was a problem hiding this comment.
yeah, I tried to normalize the constructor like I did elsewhere but it turns out we use the errno in tests to keep listening on random ports until we get one that works so it's non-trivial
|
Also tagging a !google !EM reviewer :-) |
|
/retest |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial passes of this were over 100 files of workarounds to build
bazel build --config=remote --define=admin_html=disabled --define=admin_functionality=disabled --define envoy_exceptions=disabled --define envoy_mobile_listener=disabled --define=envoy_yaml=disabled //test/performance:test_binary_size --copt=-fno-unwind-tables --copt=-fno-exceptions
Now we're in the low 70 files, but there's still work todo (see TODO). Landing now as E-M already panics on bad config, and we want to see what the binary size impact is for our E-M usage.
I will continue working on envoyproxy/envoy-mobile#176 to do proper error handling with the end goal of removing this macro.
Risk Level: low
Testing: n/a
Docs Changes:
Release Notes:
envoyproxy/envoy-mobile#176