-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notifier: adding basic oncall notifications #29820
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@phlax per usual sorry for my python |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
ah, progress, found the in file, trying to figure out why I can't run pip-compile to fix the txt |
$ pip install pip-tools
$ cd $DIR_CONTAINING_REQS
$ pip-compile --generate-hashes --reuse-hashes --allow-unsafe requirements.in |
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
yeah for some reason installing pip-compile didn't work. possibly python versioning, possibly google internal weirdness |
Eventual plan follow-up: associating opsgenie names with slack names so we can ping ocall from both envoy-maintainers and envoy-CI the week of rotation, and also pinging next-oncall the week before to give them a heads up rotaton will switch to them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
…/actions/pr_notifier (envoyproxy#29941)" This reverts commit 2e52759. Revert "build(deps): bump urllib3 from 1.26.6 to 1.26.17 in /.github/actions/pr_notifier (envoyproxy#29913)" This reverts commit 2d7e455. Revert " notifier: adding basic oncall notifications (envoyproxy#29820)" This reverts commit c495291.
…yproxy#29820)" This reverts commit c495291. Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Since slack google calendar support is deprecated, adding it back in via the PR notifier.
(theoretically) notifying general and oncall of rotation switches. This won't work (but will post that it doesn't work) if we do overrides incorrectly.