filesystem: making fileReadToEnd take absl::status #29700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssawilk
force-pushed
the
e_filesystem
branch
2 times, most recently
from
a2d6cd6
to
593eaa0
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
force-pushed
the
e_filesystem
branch
from
593eaa0
to
c25be43
Compare
|
/retest |
1 similar comment
|
/retest |
alyssawilk
requested review from
zuercher,
ggreenway,
soulxu,
mattklein123,
RyanTheOptimist,
htuch,
lizan and
yanavlasov
as code owners
ggreenway
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk Level: low
Testing: updated
Docs Changes: n/a
Release Notes: n/a
envoyproxy/envoy-mobile#176