Add a unit test for the mobile fetch client #28903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Hamilton <rch@google.com>
abeyad
reviewed
Aug 8, 2023
| // to do so. | ||
| TEST(FetchClientTest, Foo) { | ||
| Envoy::Fetch client; | ||
| client.fetch({"https://wwwfff.google.com/"}); |
There was a problem hiding this comment.
just curious, is there a reason for the "fff"?
There was a problem hiding this comment.
facepalm It was supposed to be www, but I decided to test what would happen if the client could not reach the server (in this 'cause because DNS failed). And then I forgot to switch it back. Fixed. Thanks!
abeyad
approved these changes
Aug 8, 2023
yanavlasov
approved these changes
Aug 9, 2023
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Aug 9, 2023
* Add a unit test for the mobile fetch client Signed-off-by: Ryan Hamilton <rch@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
jbohanon
pushed a commit
to solo-io/envoy-fork
that referenced
this pull request
Aug 11, 2023
* Add a unit test for the mobile fetch client Signed-off-by: Ryan Hamilton <rch@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a unit test for the mobile fetch client
Risk Level: None
Testing: New test
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A