coverage: Use upstream coverage collect script #28802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlax
force-pushed
the
cov-collect-update
branch
3 times, most recently
from
2287ed9
to
361041f
Compare
phlax
changed the title
phlax
commented
Aug 5, 2023
|
|
phlax
commented
Aug 5, 2023
phlax
commented
Aug 5, 2023
phlax
force-pushed
the
cov-collect-update
branch
from
7fa5c17
to
b081f1c
Compare
repokitteh-read-only
bot
added
api
deps
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
phlax
force-pushed
the
cov-collect-update
branch
from
d62425d
to
041711e
Compare
phlax
changed the title
phlax
commented
Aug 5, 2023
phlax
commented
Aug 5, 2023
phlax
commented
Aug 5, 2023
phlax
force-pushed
the
cov-collect-update
branch
3 times, most recently
from
a50959b
to
f55ef56
Compare
phlax
commented
Aug 6, 2023
phlax
force-pushed
the
cov-collect-update
branch
from
f55ef56
to
f7af08c
Compare
|
/retest mobile |
phlax
changed the title
|
/retest mobile again |
|
/retest mobile to be sure (network tranients afaict) |
|
/retest mobile |
phlax
force-pushed
the
cov-collect-update
branch
9 times, most recently
from
8936511
to
83a16fe
Compare
phlax
changed the title
phlax
requested review from
RyanTheOptimist,
alyssawilk,
abeyad and
wbpcode
as code owners
phlax
commented
Aug 12, 2023
phlax
force-pushed
the
cov-collect-update
branch
from
eb50128
to
970456f
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
cov-collect-update
branch
from
970456f
to
c1f5686
Compare
RyanTheOptimist
approved these changes
Aug 13, 2023
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Aug 16, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Aug 16, 2023
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Aug 17, 2023
)" This reverts commit 8004b60. Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Aug 17, 2023
…proxy#28802)"" This reverts commit 98adf91. Signed-off-by: Ryan Northey <ryan@synca.io>
alyssawilk
added a commit
to alyssawilk/envoy
that referenced
this pull request
Aug 17, 2023
)" This reverts commit 8004b60.
phlax
added a commit
that referenced
this pull request
Aug 21, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
that referenced
this pull request
Aug 22, 2023
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our custom collect script should no longer be necessary as upstream now has the support for which it was added
This speeds coverage up by ~25% in my testing, and uses a lot less disk space
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]