Reduce log spam of load shed points if not configured. #28753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
various callsites so each point gets logged about at most once. Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
|
/assign @phlax |
phlax
approved these changes
Aug 1, 2023
michaelfinch
added a commit
to michaelfinch/envoy
that referenced
this pull request
Aug 2, 2023
* main: (144 commits) eds: Adding eds caching support to grpc-mux (envoyproxy#28273) deps: Bump `build_bazel_rules_apple` -> 2.5.0 (envoyproxy#28747) deps: Bump `com_github_cyan4973_xxhash` -> 0.8.2 (envoyproxy#28745) deps: Bump `rules_rust` -> 0.26.0 (envoyproxy#28744) Revert "Golang: remove HTTP related elements from the golang network … (envoyproxy#28759) Golang: remove HTTP related elements from the golang network filter (envoyproxy#28743) build(deps): bump jaegertracing/all-in-one from `93ba12f` to `2e210e4` in /examples/shared/jaeger (envoyproxy#28740) build(deps): bump pyparsing from 3.0.9 to 3.1.1 in /mobile/docs (envoyproxy#28714) deps: Bump `com_github_bufbuild_buf` -> 1.25.0 (envoyproxy#28746) Reduce log spam of load shed points if not configured. (envoyproxy#28753) [contrib-siporoxy] fix SipTraTest.TraCompleteRetrieveRsp flakyness (envoyproxy#28660) Remove implicit deps on fmt_lib (envoyproxy#28662) UHV: harmonize check for %00 with legacy path normalization (envoyproxy#28727) build(deps): bump redis from `08a82d4` to `b0bdc1a` in /examples/redis (envoyproxy#28713) build(deps): bump otel/opentelemetry-collector from `6a76e13` to `dbf77b0` in /examples/opentelemetry (envoyproxy#28741) bazel: Switch `exec_tools` -> `tools` (envoyproxy#28729) correct some typos for thread_synchronizer.cc and outlier_detection_i… (envoyproxy#28707) Cleanup ActiveUdpListenerBase dispatcher call (envoyproxy#28697) cleanup: moving checkApiConfigSourceNames to unnamed namespace (envoyproxy#28701) ci: Pass through `--nocache_test_results` correctly on scheduled runs (envoyproxy#28690) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just #28654 now that CI issues have been addressed.
Commit Message: Reduce log spam of load shed points if not configured.
Additional Description: LOG_ONCE_IF in the various callsites so each point gets logged about at most once.
Risk Level: low
Testing: unit test
Docs Changes: na
Release Notes: na
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]