protobuf util: correct name for repeatedptrfield #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akonradi
force-pushed
the
patch-1
branch
2 times, most recently
from
15945b0
to
6ed9da2
Compare
mattklein123
previously approved these changes
Dec 7, 2017
Use `Protobuf::RepeatedPtrField<>` as the argument type for `hash()` for consistency. Signed-off-by: Alex Konradi <akonradi@google.com>
htuch
approved these changes
Dec 7, 2017
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
* Update envoy and build opt envoy commit date: 04/10/2019 bazel version: 0.22.0 Signed-off-by: Yuchen Dai <silentdai@gmail.com> * align envoy SHA in istio.deps with WORKSPACE Signed-off-by: Yuchen Dai <silentdai@gmail.com> * add comment above the uncomment local_repository Signed-off-by: Yuchen Dai <silentdai@gmail.com>
jpsim
added a commit
that referenced
this pull request
Nov 28, 2022
Diff: 5181d23...0e8899c Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
that referenced
this pull request
Nov 29, 2022
Diff: 5181d23...0e8899c Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Use
Protobuf::RepeatedPtrField<>instead ofgoogle::protobuf::RepeatedPtrField<>as the argument type forhash()for consistency.Risk Level: Low
Testing: ran unit tests
Docs Changes: N/A
Release Notes: N/A