proto: Handle maps correctly in redact.
#18254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Gallagher <pgal@google.com>
Signed-off-by: Paul Gallagher <pgal@google.com>
|
/retest |
|
Retrying Azure Pipelines: |
|
/retest |
|
Retrying Azure Pipelines: |
|
flaky. /retest |
|
Retrying Azure Pipelines: |
|
@lizan please assign to maintainer? |
lizan
approved these changes
Sep 27, 2021
soulxu
pushed a commit
to soulxu/envoy
that referenced
this pull request
Oct 16, 2021
proto: handle maps correctly in `redact`. Additional Description: Currently, when a map is marked as sensitive, `redact` will turn every key into the string "[redacted]", thereby invalidating the map. This change causes the map to only have values converted to "[redacted]". Risk Level: low Testing: unit tested. Docs Changes: Release Notes: Platform Specific Features: Signed-off-by: Paul Gallagher <pgal@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul Gallagher pgal@google.com
Commit Message: proto: handle maps correctly in
redact.Additional Description: Currently, when a map is marked as sensitive,
redactwill turn every key into the string "[redacted]", thereby invalidating the map. This change causes the map to only have values converted to "[redacted]".Risk Level: low
Testing: unit tested.
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]