-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fuzz: fix oss-fuzz crash related to channelArgsFromConfig #11641
Conversation
Signed-off-by: Arthur Yan <arthuryan@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nice PR description and the link to the original cause!
Signed-off-by: Arthur Yan <arthuryan@google.com>
Very small nit: in the description, can you link in the bug (bugs.chromium link) that you'll see on in the testcase under Issue? The testcase will expire, but the bug report won't. |
Just replaced the link to the testcase with a link to the bug in the description, along with some other minor edits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This way the failure is a ProtoValidationException and will print the bad message. I'll wait on Alex to give the +1 that it suffices for the comment earlier.
test/server/server_corpus/clusterfuzz-testcase-minimized-server_fuzz_test-5714049408172032
Outdated
Show resolved
Hide resolved
Signed-off-by: Arthur Yan <arthuryan@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
…#11641) Added regression test to server_corpus Risk Level: Low Testing: passes regression test that originally crashed on oss-fuzz Docs Changes: N/A Release Notes: N/A Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22824 Signed-off-by: Arthur Yan <arthuryan@google.com>
…#11641) Added regression test to server_corpus Risk Level: Low Testing: passes regression test that originally crashed on oss-fuzz Docs Changes: N/A Release Notes: N/A Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22824 Signed-off-by: Arthur Yan <arthuryan@google.com> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
Signed-off-by: Arthur Yan arthuryan@google.com
Commit Message: Fixes oss-fuzz crash (panic: not reached) due to oneof name not being set
Additional Description:
Risk Level: Low
Testing: passes regression test that originally crashed on oss-fuzz
Docs Changes: N/A
Release Notes: N/A
Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22824