build: use clang-10 #11222

lizan · 2020-05-15T21:39:52Z

Risk Level: Med
Testing: CI
Docs Changes: Changed clang references
Release Notes: Added

Signed-off-by: Lizan Zhou lizan@tetrate.io

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

htuch

Looks good modulo figuring out the libtooling BUILD file.
/wait

stale · 2020-05-25T15:21:38Z

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

stale · 2020-06-02T09:15:53Z

This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

lizan · 2020-06-04T00:59:17Z

@htuch should be ready to go

wrowe · 2020-06-04T14:02:58Z

@lizan please note, we have several source fixes on #11107 for formatting / tidy based on clang-format-10 that you may wish to pick up (either by merging to master, merging this patch from master, or cherry-pick them from that patch branch

htuch

LGTM, rad!

mattklein123 · 2020-06-04T20:17:48Z

Can you check CI?

/wait

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

wrowe · 2020-06-05T03:25:48Z

See changes to source/ and test/ (ignore the others) from this specific patch revert, I suspect you want a number of these changes on this PR, Sunjay has pulled them from the RBE work... d34894a

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

lizan · 2020-06-10T21:28:23Z

source/common/stats/symbol_table_impl.h

-    const char* cdata = reinterpret_cast<const char*>(stat_name.data());
-    absl::string_view data_as_string_view = absl::string_view(cdata, stat_name.dataSize());
-    return H::combine(std::move(h), data_as_string_view);
+    return H::combine(std::move(h), stat_name.dataAsStringView());


cc @jmarantz PTAL at this file

lizan · 2020-06-10T21:30:52Z

test/run_envoy_bazel_coverage.sh

@@ -49,7 +49,7 @@ if [[ "$VALIDATE_COVERAGE" == "true" ]]; then
  if [[ "${FUZZ_COVERAGE}" == "true" ]]; then
    COVERAGE_THRESHOLD=27.0
  else
-    COVERAGE_THRESHOLD=97.0
+    COVERAGE_THRESHOLD=96.6


re: coverage threshold, it is because LLVM 10.0 generate trace differently for default: and empty lines, e.g.:

https://storage.googleapis.com/envoy-pr/11222/coverage/source/common/tracing/http_tracer_impl.cc.gcov.html

If it's purely an artifact of measurement, I'm OK with adjusting the limit, but it would be good to get this heading North.

yeah now it's easier for us to actually exclude lines in coverage with some post processing, as lcov format is much easier to work with, but it's beyond the scope of this PR

lizan · 2020-06-11T22:17:42Z

@htuch finally all CI passed, PTAL

htuch

LGTM modulo nghttp2 patch thread.

bazel/foreign_cc/nghttp2.patch

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

This reverts commit 74bcb11. Signed-off-by: Lizan Zhou <lizan@tetrate.io>

htuch

LGTM, thanks!

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

wrowe · 2020-06-17T14:30:33Z

Reviewing status this morning of the "cancelled" coverage run, this PR is passing all tests;

sent 62,518,874 bytes received 92,045 bytes 41,740,612.67 bytes/sec
total size is 62,133,086 speedup is 0.99
Code coverage 96.6 is good and higher than limit of 96.5

Our work on the Windows CI in 11107 and work to evaluate LLVM clang-cl 10 as an alternative Windows compiler are all gated on this PR, if it could be merged promptly.

lizan · 2020-06-17T18:05:05Z

/azp run

azure-pipelines · 2020-06-17T18:05:17Z

Azure Pipelines successfully started running 1 pipeline(s), but failed to run 2 pipeline(s).

lizan · 2020-06-17T21:07:58Z

@wrowe I should be able to merge once CI pass

Risk Level: Med Testing: CI Docs Changes: Changed clang references Release Notes: Added Signed-off-by: Lizan Zhou <lizan@tetrate.io> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>

Risk Level: Med Testing: CI Docs Changes: Changed clang references Release Notes: Added Signed-off-by: Lizan Zhou <lizan@tetrate.io>

Risk Level: Med Testing: CI Docs Changes: Changed clang references Release Notes: Added Signed-off-by: Lizan Zhou <lizan@tetrate.io> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>

lizan added 2 commits May 15, 2020 21:38

update references to clang-10

cd49a48

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

format

76388dc

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

lizan requested a review from htuch May 15, 2020 21:39

lizan requested a review from dio as a code owner May 15, 2020 21:39

jmarantz assigned dio and htuch May 18, 2020

htuch reviewed May 18, 2020

View reviewed changes

repokitteh-read-only bot added the waiting label May 18, 2020

stale bot added the stale stalebot believes this issue/PR has not been touched recently label May 25, 2020

stale bot closed this Jun 2, 2020

lizan added 2 commits June 3, 2020 13:04

Merge remote-tracking branch 'upstream/master' into clang-10-build

58895d2

fix libtooling

4f60e67

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

lizan reopened this Jun 3, 2020

stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Jun 3, 2020

repokitteh-read-only bot removed the waiting label Jun 3, 2020

lizan added 4 commits June 3, 2020 13:53

fix

181ea6b

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

fix

086440e

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

fix booster test

386b46e

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

Merge remote-tracking branch 'upstream/master' into clang-10-build

93b26de

htuch previously approved these changes Jun 4, 2020

View reviewed changes

repokitteh-read-only bot added the waiting label Jun 4, 2020

add nghttp2 patch

9302933

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

lizan dismissed htuch’s stale review via 9302933 June 4, 2020 21:21

repokitteh-read-only bot removed the waiting label Jun 4, 2020

lizan added 2 commits June 10, 2020 03:37

Merge remote-tracking branch 'upstream/master' into clang-10-build

bd27495

fix tap base properly

0f2a434

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

lizan commented Jun 10, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into clang-10-build

89a83ad

htuch reviewed Jun 11, 2020

View reviewed changes

bazel/foreign_cc/nghttp2.patch Show resolved Hide resolved

lizan added 2 commits June 12, 2020 14:52

bump nghttp2 version instead of patch

74bcb11

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

Revert "bump nghttp2 version instead of patch"

2b4bc79

This reverts commit 74bcb11. Signed-off-by: Lizan Zhou <lizan@tetrate.io>

htuch previously approved these changes Jun 15, 2020

View reviewed changes

lizan added 2 commits June 15, 2020 15:50

Merge remote-tracking branch 'upstream/master' into clang-10-build

625a0ba

make coverage timeout flexible

3ee4a97

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

lizan dismissed htuch’s stale review via 3ee4a97 June 15, 2020 22:51

lizan added 2 commits June 16, 2020 13:37

adjust cov threshold again

e02b0e2

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

Merge remote-tracking branch 'upstream/master' into clang-10-build

6fb1aab

htuch approved these changes Jun 17, 2020

View reviewed changes

lizan merged commit 8d7cd0c into envoyproxy:master Jun 18, 2020

lizan deleted the clang-10-build branch June 18, 2020 06:55

songhu pushed a commit to songhu/envoy that referenced this pull request Jun 25, 2020

build: use clang-10 (envoyproxy#11222)

63eb86c

Risk Level: Med Testing: CI Docs Changes: Changed clang references Release Notes: Added Signed-off-by: Lizan Zhou <lizan@tetrate.io>

lizan mentioned this pull request Oct 21, 2020

Consolidate/(re)tag Envoy Docker images #13649

Closed

mk46 mentioned this pull request Nov 27, 2020

git push checker uses potentially incompatible clang-format #2306

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: use clang-10 #11222

build: use clang-10 #11222

lizan commented May 15, 2020 •

edited

Loading

htuch left a comment

stale bot commented May 25, 2020

stale bot commented Jun 2, 2020

lizan commented Jun 4, 2020

wrowe commented Jun 4, 2020

htuch left a comment

mattklein123 commented Jun 4, 2020

wrowe commented Jun 5, 2020

lizan Jun 10, 2020

lizan Jun 10, 2020

htuch Jun 10, 2020

lizan Jun 11, 2020

lizan commented Jun 11, 2020

htuch left a comment

htuch left a comment

wrowe commented Jun 17, 2020

lizan commented Jun 17, 2020

azure-pipelines bot commented Jun 17, 2020

lizan commented Jun 17, 2020 •

edited

Loading

build: use clang-10 #11222

build: use clang-10 #11222

Conversation

lizan commented May 15, 2020 • edited Loading

htuch left a comment

Choose a reason for hiding this comment

stale bot commented May 25, 2020

stale bot commented Jun 2, 2020

lizan commented Jun 4, 2020

wrowe commented Jun 4, 2020

htuch left a comment

Choose a reason for hiding this comment

mattklein123 commented Jun 4, 2020

wrowe commented Jun 5, 2020

lizan Jun 10, 2020

Choose a reason for hiding this comment

lizan Jun 10, 2020

Choose a reason for hiding this comment

htuch Jun 10, 2020

Choose a reason for hiding this comment

lizan Jun 11, 2020

Choose a reason for hiding this comment

lizan commented Jun 11, 2020

htuch left a comment

Choose a reason for hiding this comment

htuch left a comment

Choose a reason for hiding this comment

wrowe commented Jun 17, 2020

lizan commented Jun 17, 2020

azure-pipelines bot commented Jun 17, 2020

lizan commented Jun 17, 2020 • edited Loading

lizan commented May 15, 2020 •

edited

Loading

lizan commented Jun 17, 2020 •

edited

Loading