platform: remove re-definition of mmsghdr for Android targets #10521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 25, 2020 12:47
Signed-off-by: Jose Nino <jnino@lyft.com>
|
Chatted with @danzh2010 in #envoy-udp-quic-dev |
ggreenway
approved these changes
Mar 25, 2020
danzh2010
approved these changes
Mar 25, 2020
|
The |
junr03
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Mar 26, 2020
Description: updates envoy to f4931758d29b2aa6be89900650aeee54addb1827. This brings a few relevant changes for envoy mobile: - Additional observability for virtual clusters: envoyproxy/envoy#10474 envoyproxy/envoy#10499 envoyproxy/envoy#10501 - 32-bit compatibility fix envoyproxy/envoy#10510 - Android re-definition of `mmsghdr` fix envoyproxy/envoy#10521 Signed-off-by: Jose Nino <jnino@lyft.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: updates envoy to f493175. This brings a few relevant changes for envoy mobile: - Additional observability for virtual clusters: #10474 #10499 #10501 - 32-bit compatibility fix #10510 - Android re-definition of `mmsghdr` fix #10521 Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: updates envoy to f493175. This brings a few relevant changes for envoy mobile: - Additional observability for virtual clusters: #10474 #10499 #10501 - 32-bit compatibility fix #10510 - Android re-definition of `mmsghdr` fix #10521 Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: remove Android flag that caused re-definition issues with Android's ndk for
mmsghdr.Risk Level: low given Envoy Mobile is the only active, well-known Android target for Envoy.
Testing: built Envoy Mobile for Android successfully.
Signed-off-by: Jose Nino jnino@lyft.com