dns cache: do not runRemoveCallbacks if runAddUpdateCallbacks has not fired #10003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 10, 2020 22:26
|
This was originally reproduced in Envoy Mobile envoyproxy/envoy-mobile#671 |
mattklein123
approved these changes
Feb 11, 2020
This was referenced Feb 11, 2020
junr03
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Feb 11, 2020
This bump brings in two relevant fixes envoyproxy/envoy#10002 fixes #677 envoyproxy/envoy#10003 fixes #671 Signed-off-by: Jose Nino <jnino@lyft.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: previously the DnsCacheImpl would fire runRemoveCallbacks for a host when TTL expired even if it had potentially never fired runAddUpdateCallbacks. Therefore, the callback's target (the Dynamic Forward Proxy Cluster) reaches bad state. The Cluster tries to remove a host that doesn't exist from its point of view and trips this assertion. This PR ensures that the DnsCacheImpl only fires runRemoveCallbacks if it has previously fired runAddUpdateCallbacks for a host.
Risk Level: low, fixes erroneous behavior.
Testing: added repro in existing unit tests, and verified that updated code fixed the test.
Signed-off-by: Jose Nino jnino@lyft.com