fixed file name dump method workflows #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #200 +/- ##
==========================================
+ Coverage 88.79% 88.81% +0.02%
==========================================
Files 32 32
Lines 5799 5812 +13
==========================================
+ Hits 5149 5162 +13
Misses 650 650
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@raulconchello what's the default value for the project id? Project_id has to be a valid uuid4, it is provided by the user, and it now becomes necessary. That is, if no project id is specified what happens when one tires to save the result? |
Q-lds
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dump method was giving the following name:
{experiment_id}--{atomic_id}the correct one is:
{project_id}--{experiment_id}--{atomic_id}