Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication Refactor #126

Merged
merged 4 commits into from
Nov 10, 2022
Merged

Authentication Refactor #126

merged 4 commits into from
Nov 10, 2022

Conversation

shahidee44
Copy link
Collaborator

@shahidee44 shahidee44 commented Nov 10, 2022

Description

  • Update to DeviceAWS. Removing the need to request for keys.
  • Updated create_device function to remove some of the old initlisation parameters of DeviceAWS.
  • Updated Notebook Example 10 for updated authentication with Braket.
  • Updated test_qpu_braket.py to accomandate new changes with DeviceAWS

Checklist

  • I have performed a self-review of my code.
  • [ x I have commented my code and used numpy-style docstrings
  • My changes generate no new warnings
  • I have added/updated tests to make sure bugfix/feature works.
  • New and existing unit tests pass locally with my changes.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

test_all.py

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #126 (51d4418) into dev (80b0b6b) will decrease coverage by 0.00%.
The diff coverage is 8.16%.

@@            Coverage Diff             @@
##              dev     #126      +/-   ##
==========================================
- Coverage   87.30%   87.30%   -0.01%     
==========================================
  Files          67       67              
  Lines        8924     8922       -2     
==========================================
- Hits         7791     7789       -2     
  Misses       1133     1133              
Impacted Files Coverage Δ
openqaoa/backends/qpus/qaoa_braket_qpu.py 21.59% <0.00%> (-0.51%) ⬇️
tests/test_qpu_braket.py 10.38% <6.97%> (-0.44%) ⬇️
openqaoa/devices.py 50.00% <33.33%> (+1.42%) ⬆️
openqaoa/optimizers/result.py 90.69% <0.00%> (-1.17%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shahidee44 shahidee44 marked this pull request as ready for review November 10, 2022 08:12
@vishal-ph
Copy link
Collaborator

@shahidee44, you forgot to update the notebook? (notebook 10 in the examples folder)

@vishal-ph vishal-ph merged commit 86fa619 into dev Nov 10, 2022
@vishal-ph vishal-ph deleted the fix_authentication_refactor branch November 10, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants