WIP: get rid of clip_rect_margin #4294
Draft
+55
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@varphone you may wanna test this to see I didn't break your custom window frames |
emilk
force-pushed
the
emilk/no-clip-margin
branch
from
781fde5
to
2b4aaf3
Compare
emilk
force-pushed
the
emilk/no-clip-margin
branch
from
2b4aaf3
to
d74a769
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clip_rect_marginis an ugly hack that I rather not have.This PR sets it to zero.
The margins of a window is now added to the inside of any ScrollArea in that window.
Why is there a
clip_rect_margin?Consider the problem of putting something with a frame (e.g. a button) inside a scroll area.
The button will be places so that the middle of its outer stroke is right on the edge of the scroll area.
This means only half of the stroke width will be visible. Buttons also grow when hovered, exacerbating the problem.
There are three potential solutions:
clip_rect_margin, allowing widgets to "color outside the lines"Border#4019