Fixes build of examples/hello_world_par on Linux #3795
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
reviewed
Jan 22, 2024
| @@ -9,7 +9,7 @@ publish = false | |||
|
|
|||
|
|
|||
| [dependencies] | |||
| eframe = { path = "../../crates/eframe", default-features = false, features = [ | |||
| eframe = { path = "../../crates/eframe", features = [ | |||
| # accesskit struggles with threading | |||
There was a problem hiding this comment.
We had default-features = false because "accesskit struggles with threading", so we probably need to test this a bit first. Maybe that comment is out-dated and no longer relevant
There was a problem hiding this comment.
I just tested this and got a panic due to a failed assertion on crates/egui/src/context.rs line 2754. I don't think AccessKit is struggling here, but there is definitely a bug in this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds default-features to the
eframedependency inhello-world-par, fixingwinit's build error ("The platform you're compiling for is not supported by winit")