Fix property normalization #16559
Merged
Fix property normalization #16559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Released the upstream change in glimmer-vm 0.34.0, and pushed the version bump commit here. |
|
👏 thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on glimmerjs/glimmer-vm#801, once that is released we should edit this PR to also upgrade the glimmer packages (I made a small breaking change in the glimmer Environment API).
Fixes #16311
Fixes #16477
The root cause was that glimmer was not doing correct property normalization, and Ember was trying -- incorrectly -- to compensate for that with a
toLowerCase, which was enough to get our existing tests to pass but was not the correct semantics.