Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test around moduleName mutation #14196

Closed
wants to merge 65 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
1298ee6
Strip all non-enabled features.
rwjblue Jul 25, 2016
c5ccb88
Allow tags to be build in CI.
rwjblue Jul 25, 2016
1234110
Add 2.8.0-beta.1 to CHANGELOG.md.
rwjblue Jul 25, 2016
2d3ccd9
Fix import from ember-htmlbars using ember-glimmer.
rwjblue Jul 25, 2016
09b411b
Release v2.8.0-beta.1.
rwjblue Jul 26, 2016
0f0e3c0
[CLEANUP] Unify glimmer behavior with htmlbars and remove unsed code
krisselden Jul 26, 2016
9e19860
Remove `View#createElement`.
Jul 25, 2016
72cc2fa
Remove `View#destroyElement` method.
Jul 25, 2016
2414d71
Migrate `isVisible` tests to ember-glimmer package.
Jul 25, 2016
c68e8c7
Expose `Ember.ApplicationInstance.setupRegistry` for tooling.
Jul 30, 2016
9460f44
[BUGFIX beta] Fix ember-metal/cache
Jul 29, 2016
cebdf72
[BUGFIX release] Add more info to the `Ember.Binding` deprecation.
Jul 27, 2016
d89d3f3
Disallow paths beginning with @ in templates
courajs Jul 27, 2016
5375f39
[BUGFIX beta] Avoid using `.env` property on components.
Jul 26, 2016
939109a
[BUGFIX] Fix template meta lookup
asakusuma Jul 26, 2016
75fce1b
Fix bower-auto-build description
mike-north Jul 26, 2016
7b5186c
Add v2.8.0-beta.2 to CHANGELOG.md.
rwjblue Aug 1, 2016
377bef2
Release v2.8.0-beta.2.
rwjblue Aug 1, 2016
aec1fa6
[BUGFIX beta] attributeBindings not working with `role`
cibernox Aug 2, 2016
014260a
[DOC release] Use dash for partial naming
wagenet Aug 4, 2016
73973a2
[BUGFIX beta] Add tests for visit() with shouldRender set to false
Aug 4, 2016
6dff557
[BUGFIX beta] Pass environment options forward to Engines
Aug 4, 2016
af0a422
[DOC release] Improve Ember.deprecate documentation
wagenet Aug 4, 2016
0531c18
[BUGFIX beta] `fillIn` only sets value to first match.
Serabe Aug 5, 2016
f4a8896
[DOC release] Add documentation for click 2nd argument
Aug 1, 2016
d3dd7cd
[DOC release] Boolean `attributeBindings` documentation updated
Serabe Aug 6, 2016
66541cb
[DOC release] Fix `setEach` documentation
Serabe Aug 6, 2016
bcf4da0
[DOC release] Fix documentation of Route queryParamsDidChange.
GUI Jul 30, 2016
bda1a02
Restructure code to avoid awkward compilation
chancancode Aug 8, 2016
c93e31f
`POST_INIT` do not take arguments
chancancode Aug 8, 2016
d4d620f
[CLEANUP] Remove `init` arguments checking
chancancode Aug 8, 2016
b4ed1a3
[BUGFIX beta] Bump router.js so that getHandlers is invoked lazily
Aug 8, 2016
5a01efc
Remove dead code
mitchlloyd Aug 10, 2016
0d67c55
[DOC] Fix code blocks for includes
Aug 10, 2016
c1c5c28
[BUGFIX beta] Ensure substates properly work with resetNamespace
Aug 11, 2016
eb23747
[BUGFIX release] Update route-recognizer to v0.2.1.
Aug 12, 2016
5fefce9
[BUGFIX beta] Update router.js to fix Phantom 1.9 issues.
rwjblue Aug 13, 2016
69a1a0b
[BUGFIX beta] Update router.js to fix Phantom 1.9 issues.
simonihmig Aug 15, 2016
d6e8401
Failing test for #14010
alisdair Aug 15, 2016
7987f8a
Default queryParams in link-to must have values
alisdair Aug 15, 2016
58bba0b
[DOC relase] Improve `mut` documentation
Serabe Aug 14, 2016
b991b31
Add 2.7.1 to the CHANGELOG.md.
Aug 16, 2016
30ad514
Add v2.8.0-beta.3 to CHANGELOG.md.
Aug 16, 2016
10f3507
Release v2.8.0-beta.3.
Aug 16, 2016
cf71482
[BUGFIX beta] Update route-recognizer.
nathanhammond Aug 16, 2016
30c1ce5
[BUGFIX beta] Prevent issues with revalidation during teardown.
rwjblue Aug 22, 2016
53ceb4c
[DOC beta] Improve `Route#render` documentation
Serabe Aug 9, 2016
ab7af97
[BUGFIX beta] Check that handler exists before triggering event
Aug 18, 2016
75be1a7
[BUGFIX beta] Avoid assertion when `id=` is provided to tagless compo…
rwjblue Aug 21, 2016
df66e3a
[BUGFIX beta] Call ArrayProxy's content change hooks
mmun Aug 23, 2016
5b38d5f
[BUGFIX beta] Avoid rerendering outlet state during router destruction.
Aug 24, 2016
19d5f6c
[BUGFIX beta] Clone additional parent dependencies into engine instan…
dgeb Aug 22, 2016
8a6dcf1
[BUGFIX beta] Ensure engines are destroyed before top-level views.
asakusuma Aug 17, 2016
941e400
[BUGFIX beta] Ensure injections happen in engine instances.
Aug 27, 2016
09a0432
[GLIMMER] Ensure all components have injections.
Aug 27, 2016
f516c6f
Use a dictionary for the view registry
chancancode Aug 25, 2016
c50cf75
Add 2.8.0-beta.4 to CHANGELOG.md.
Aug 30, 2016
a681d8b
Fix issue with cherry-picked test cleanup.
Aug 30, 2016
dd60011
Release v2.8.0-beta.4.
Aug 30, 2016
5aa5875
[BUGFIX beta] Fix cleanup
krisselden Aug 30, 2016
08803e3
Fix issue with document.contains on IE.
Aug 30, 2016
2dbde63
Merge pull request #14159 from emberjs/fix-child-views-leak
rwjblue Aug 30, 2016
cfbf965
Add 2.8.0-beta.5 to CHANGELOG.md.
Aug 31, 2016
9423fc6
Release v2.8.0-beta.5.
Aug 31, 2016
56f350a
Add failing test around moduleName mutation
asakusuma Sep 2, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Default queryParams in link-to must have values
Fixes #14010

(cherry picked from commit 266474d)
  • Loading branch information
alisdair authored and Robert Jackson committed Aug 15, 2016
commit 7987f8a297de3985b8cc100f039f6f74c342a282
2 changes: 1 addition & 1 deletion packages/ember-htmlbars/lib/components/link-to.js
Original file line number Diff line number Diff line change
Expand Up @@ -805,7 +805,7 @@ const LinkComponent = EmberComponent.extend({
if (lastParam && lastParam.isQueryParams) {
queryParams = params.pop();
} else {
queryParams = {};
queryParams = { values: {} };
}
this.set('queryParams', queryParams);

Expand Down