Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Fixes #12899 #12934

Merged
merged 1 commit into from
Feb 9, 2016
Merged

Conversation

asakusuma
Copy link
Contributor

Ensure transitionTo returns a transition object. Addresses #12899

@asakusuma asakusuma changed the title Ensure transitionTo returns a transition object [BUGFIX beta] Fixes #12899 Feb 9, 2016
@rwjblue
Copy link
Member

rwjblue commented Feb 9, 2016

Sorry for not getting this done quicker, but thank you for tackling it!

containing a mapping of query parameters
@return {Transition} the transition object associated with this
attempted transition
@public
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets land this fix without changing public API (docs here are great, but change @public to @private), then submit a separate documentation only PR that updates?

Ensure transitionTo returns a transition object. Addresses
emberjs#12899
@rwjblue
Copy link
Member

rwjblue commented Feb 9, 2016

👍

@asakusuma
Copy link
Contributor Author

No problem, @krisselden got me on the right approach

@rwjblue
Copy link
Member

rwjblue commented Feb 9, 2016

Yeah, he is awesome like that. 😺

I need to determine if this bug is in 2.3.1, and backport to release if it is....

rwjblue added a commit that referenced this pull request Feb 9, 2016
@rwjblue rwjblue merged commit 8455352 into emberjs:master Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants