Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Upgrade htmlbars to 0.14.14 #12877

Merged
merged 1 commit into from
Jan 31, 2016
Merged

Conversation

mmun
Copy link
Member

@mmun mmun commented Jan 31, 2016

For more information see tildeio/htmlbars#447.

This PR contains two fixes to htmlbars

1. A fix to the tokenizer: tildeio/htmlbars#443
2. A fix to the behavior of text input cursors: tildeio/htmlbars#447
@mmun mmun changed the title [BUGFIX release] Fix text input cursor behavior [BUGFIX release] Upgrade htmlbars to 0.14.14 Jan 31, 2016
@rwjblue
Copy link
Member

rwjblue commented Jan 31, 2016

I restarted the build after #12879, but it may require a rebase to grab those changes.

rwjblue added a commit that referenced this pull request Jan 31, 2016
[BUGFIX release] Upgrade htmlbars to 0.14.14
@rwjblue rwjblue merged commit d1553aa into master Jan 31, 2016
@rwjblue rwjblue deleted the fix-input-cursor branch January 31, 2016 14:31
@Dhaulagiri
Copy link
Contributor

How feasible is it to backport this fix to earlier releases in the 2.x series? (I'm happy to do the actual work)

@mmun
Copy link
Member Author

mmun commented Mar 17, 2016

@Dhaulagiri It should be extremely trivial (maybe even just bumping the version in package.json).

I am concerned that you're on an older 2.x release. There should be no reason you are not on the very latest version of Ember. Ember 2.4 being declared an LTS release is even more of a reason to upgrade. Is there a regression that's preventing you from upgrading?

@rwjblue
Copy link
Member

rwjblue commented Mar 17, 2016

Agree with @mmun, there should be no blockers from 2.0 through 2.4, if there are we should fix them...

@Dhaulagiri
Copy link
Contributor

It should be extremely trivial (maybe even just bumping the version in package.son)

👍

Is there a regression that's preventing you from upgrading?

There is a longer story here that is probably better off discussed elsewhere (emberconf?).

tl;dr We have an old karma-based test suite and non-standard data adapter that seem to break in some unpredictiable way with every release of Ember. After prolonged effort we just recently got to 2.0 🎉. I was optimistic about quickly getting to 2.4, but our data adapter broke (due to a change to how ember wraps _super that was introduced, i think, here) and our old test suite won't run at all because this hack no longer works. I haven't dug in real hard to fixing either issue due to upgrade fatigue, but I would certainly love to get things sorted out sooner than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants