Failing test for {{component}} keyword teardown. #11329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `{{component}}` keyword does not teardown previously created components
when swapping. This test demonstrates that.
Most of the infrastructure around components assumes they are static
(e.g. <my-component> cannot become a <foo-component> after it is
rendered). As such, there were some holes in destruction for the one
dynamic case (the {{component}} helper).
This commit detects when the underlying component has changed and
ensures that the component is scheduled for destruction before the new
component is swapped in.
It also fixes a similar issue with the view helper.
rwjblue
added a commit
that referenced
this pull request
Jun 12, 2015
Failing test for {{component}} keyword teardown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
{{component}}keyword does not teardown previously created componentswhen swapping. This test demonstrates that.
JSBin Demo: http://emberjs.jsbin.com/rwjblue/571/edit.