Make positionalParams static, and remove makeBoundHelper. #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes a few additional bug fixes from the prebuilt version that was used before (which was roughly 0.4.7).
This dovetails with a corresponding update to Ember itself. Support for prior Ember versions is preserved by keeping both versions. When support for 1.13.0-1.13.5 and 2.0.0-beta.0-2.0.0-beta.3 can be removed, the lines with comments can be removed.
`Ember.HTMLBars.makeBoundHelper` is deprecated in favor of `Ember.Helper.helper` and the API is the same.
ef4
added a commit
that referenced
this pull request
Jul 31, 2015
Make positionalParams static, and remove makeBoundHelper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
Note: the modal dialog tests are failing, seemingly for unrelated reasons (but I could be wrong).