Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Voice Broadcast] Remove chunks from the room attachments #7656

Merged
merged 2 commits into from
Nov 29, 2022
Merged

[Voice Broadcast] Remove chunks from the room attachments #7656

merged 2 commits into from
Nov 29, 2022

Conversation

Florian14
Copy link
Contributor

Type of change

  • WIP Feature
  • Bugfix
  • Technical
  • Other :

Content

Remove the voice messages related to a VB from the room attachments.

Motivation and context

Improve #7127

Screenshots / GIFs

Tests

  1. Record a VB in a room
  2. Send several media and files in the room (voice messages, images, videos, pdf, etc...)
  3. Verify that the voice messages related to the VB are not displayed in the attachments lists (room details -> uploads)

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@sonarcloud
Copy link

sonarcloud bot commented Nov 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Florian14 Florian14 requested review from a team and jmartinesp and removed request for a team November 29, 2022 08:03
@Florian14 Florian14 added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Nov 29, 2022
jmartinesp
jmartinesp approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I can't see anything related to voice broadcast in the attachments section.

Base automatically changed from feature/fre/voice_broadcast_buffering to develop November 29, 2022 16:43
@Florian14 Florian14 merged commit 4b3e36d into develop Nov 29, 2022
@Florian14 Florian14 deleted the feature/fre/voice_broadcast_room_attachments branch November 29, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinesp jmartinesp jmartinesp approved these changes

Assignees
No one assigned
Labels
Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Florian14 @jmartinesp