Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-vite): start Vite error #3189

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

caoxiemeihao
Copy link
Member

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Node.js v16+ must check in advance if the directory exists, while v14 works fine 😅

I developed @electron/forge-plugin-vite using the v14 version :(

@caoxiemeihao caoxiemeihao requested a review from a team as a code owner March 9, 2023 04:56
@caoxiemeihao caoxiemeihao changed the title fix: start Vite error fix(#3187): start Vite error Mar 9, 2023
@erickzhao erickzhao changed the title fix(#3187): start Vite error fix(plugin-vite): start Vite error Mar 9, 2023
@erickzhao erickzhao added this pull request to the merge queue Mar 10, 2023
Merged via the queue into electron:main with commit 3e6729b Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants