ci: fix the build and tests #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
approved these changes
Feb 22, 2023
VerteDinde
reviewed
Feb 22, 2023
| run: | | ||
| npm install -g npm@8.3.1 | ||
| npm install -g npm@latest | ||
| npm install -g npm@8 |
There was a problem hiding this comment.
Not blocking on this, but since we were using 8.3.1 before, should we maybe pin the install to that version?
There was a problem hiding this comment.
Note that 8.3.1 was just used as a temporary downgrade before upgrading to the latest due to some GHA-related bug.
MarshallOfSound
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please merge this before GHA decides it hates me again