Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Simplify if statements #268

Merged
merged 1 commit into from
Mar 27, 2019
Merged

style: Simplify if statements #268

merged 1 commit into from
Mar 27, 2019

Conversation

Richienb
Copy link
Contributor

In this PR, I simplified the IF statements by removing the curcly braces and removing the indent.

In other words, I turned this:

if (process.platform !== 'darwin') {
  app.quit()
}

into this:

if (process.platform !== 'darwin') app.quit()

@Richienb Richienb changed the title Simplify if statements Style: Simplify if statements Mar 27, 2019
@Richienb Richienb changed the title Style: Simplify if statements style: Simplify if statements Mar 27, 2019
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

electron-quick-start follows standard js, so this PR looks fine. Thanks for the patch!

@ckerr ckerr merged commit dbc225c into electron:master Mar 27, 2019
@Richienb Richienb deleted the patch-1 branch March 28, 2019 03:14
erickzhao pushed a commit that referenced this pull request Dec 8, 2020
erickzhao pushed a commit that referenced this pull request Dec 8, 2020
erickzhao pushed a commit that referenced this pull request Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants