[7.17] [ML] Data Frame Analytics: Fix field name escaping for Vega based scatterplot matrix. (#193386) #193841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
2 tasks
darnautov
approved these changes
Sep 24, 2024
…tterplot matrix. (elastic#193386) Field names with `\n` would fail to render the DFA scatterplot matrix: <img width="804" alt="image" src="https://github.com/user-attachments/assets/26e356b8-236d-4255-b556-2ebc2e5db4fc"> This fixes the escaping and adds unit tests. The fix isn't 100% ideal because there are cases when we may end up with an additional backslash being rendered for labels of the scatterplot. However, all other variations I tried caused rendering problems of the charts and rendering would fail completely. For example, just escaping `\n` without the general backslash escaping causes the following Vega error: `Duplicate scale or projection name: "child__row_my_numbercolumn_my_number_x"` On the other hand escaping just the backslash without the additional `\n` escaping causes an "expression parse error" in in Vega and the chart wouldn't render. Note this PR just focuses on escaping for the Vega spec for the scatterplot matrix. There are still other places in the UI (data grid headers, fields selector). <img width="792" alt="image" src="https://github.com/user-attachments/assets/35532741-7a13-4707-b8da-c72dcc8c935b"> - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 194d630)
walterra
force-pushed
the
backport/7.17/pr-193386
branch
from
cce0d38
to
de15eed
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @walterra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto7.17:Questions ?
Please refer to the Backport tool documentation