Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Console] UX Improvements for phase 2 (#190698) #193169

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@sabarasaba
Copy link
Member

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
console 268 250 -18

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/monaco 122 123 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
console 462.2KB 208.1KB -254.1KB
devTools 7.7KB 7.7KB +2.0B
total -254.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
console 38.4KB 40.2KB +1.8KB
kbnUiSharedDeps-srcJs 3.4MB 3.4MB +2.9KB
total +4.7KB
Unknown metric groups

API count

id before after diff
@kbn/monaco 122 123 +1

ESLint disabled in files

id before after diff
@kbn/monaco 7 8 +1
console 3 2 -1
total -0

Total ESLint disabled count

id before after diff
@kbn/monaco 11 12 +1
console 47 46 -1
total -0

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

@kibanamachine kibanamachine merged commit fac293c into elastic:8.x Sep 18, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants