Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rowgroup, row and cell attributes to log stream components #192841

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add rowgroup, row and cell attributes to log stream components #192841

wants to merge 4 commits into from

Conversation

gbamparop
Copy link
Contributor

Adds the following roles:

  • rowgroup to the logStream wrapper
  • row and cell to the separator components (Showing entries from ...)
  • row and cell to the extra components (Extend time frame by...)

Closes https://github.com/elastic/observability-accessibility/issues/123

@gbamparop gbamparop requested a review from a team as a code owner September 13, 2024 10:43
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 13, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@gbamparop gbamparop added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to the previous minor version (i.e. one version back from main) labels Sep 13, 2024
@gbamparop
Copy link
Contributor Author

@elasticmachine merge upstream

@gbamparop
Copy link
Contributor Author

@elasticmachine merge upstream

@gbamparop
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 23, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: fc95f34
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-192841-fc95f341d3bc

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
logsShared 140.3KB 140.5KB +164.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gbamparop @obltmachine @kibana-ci @elasticmachine