[ftr] migrating 'saved_objects_management/bulk' API integration test to deployment-agnostic one #192070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlemeshko
added
release_note:skip
rudolf
approved these changes
Sep 5, 2024
|
holding back merging until https://github.com/elastic/qaf-tests/issues/94 is resolved |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
1 task
gergoabraham
pushed a commit
to gergoabraham/kibana
that referenced
this pull request
Sep 13, 2024
…to deployment-agnostic one (elastic#192070) ## Summary _The goal is to consolidate 2 existing test files with identical logic into a single, deployment-agnostic test file:_ Files to be replaced: - test/api_integration/apis/saved_objects_management/bulk_delete.ts - test/api_integration/apis/saved_objects_management/bulk_get.ts - x-pack/test_serverless/api_integration/test_suites/common/saved_objects_management/bulk_delete.ts - x-pack/test_serverless/api_integration/test_suites/common/saved_objects_management/bulk_get.ts New test file: - x-pack/test/api_integration/deployment_agnostic/apis/saved_objects_management/bulk_delete.ts - x-pack/test/api_integration/deployment_agnostic/apis/saved_objects_management/bulk_get.ts The migration leverages the serverless test file as a basis for the new deployment-agnostic test. Necessary modifications are minimal and include FTR context provider & its services to ensure compatibility across different environments. Lastly new file has to be loaded into both the serverless and stateful config files under `x-pack/test/api_integration/deployment_agnostic/configs` This approach ensures that the test logic remains consistent while reducing redundancy and maintenance effort. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The goal is to consolidate 2 existing test files with identical logic into a single, deployment-agnostic test file:
Files to be replaced:
New test file:
The migration leverages the serverless test file as a basis for the new deployment-agnostic test.
Necessary modifications are minimal and include FTR context provider & its services to ensure compatibility across different environments.
Lastly new file has to be loaded into both the serverless and stateful config files under
x-pack/test/api_integration/deployment_agnostic/configsThis approach ensures that the test logic remains consistent while reducing redundancy and maintenance effort.