Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embeddable Rebuild] [Controls] Remove non-React controls from controls plugin #192017

Merged
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
d1fefd8
Delete old control files
Heenawter Sep 3, 2024
0f2ad3f
Remove legacy edit action
Heenawter Sep 3, 2024
79b7a09
Fix action tests
Heenawter Sep 3, 2024
f318f75
Remove unused types
Heenawter Sep 3, 2024
2859409
Start working on server side code
Heenawter Sep 6, 2024
7b1707c
Fix server side tests
Heenawter Sep 6, 2024
c3d1f0e
Move options list inject/extract to server
Heenawter Sep 9, 2024
651fbc8
Fix telemetry types
Heenawter Sep 9, 2024
8c09d88
Delete story services
Heenawter Sep 9, 2024
a814f2c
Fix plugin contract
Heenawter Sep 9, 2024
ed106ab
Fix more types
Heenawter Sep 9, 2024
c75aeb9
Merge branch 'main' of github.com:elastic/kibana into embeddableRebui…
Heenawter Sep 10, 2024
970347d
More cleanup after merge
Heenawter Sep 10, 2024
2f90dcc
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine Sep 10, 2024
049851f
Clean up unused translations
Heenawter Sep 10, 2024
27596ab
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine Sep 10, 2024
ddfc7f3
Fix registration + styles
Heenawter Sep 10, 2024
adf1eb9
Merge branch 'embeddableRebuild_final-controls-cleanup_2024-09-03' of…
Heenawter Sep 10, 2024
0844191
Fix types + imports
Heenawter Sep 11, 2024
9ea6f56
Fix more types
Heenawter Sep 11, 2024
bc0710a
Merge branch 'main' of github.com:elastic/kibana into embeddableRebui…
Heenawter Sep 11, 2024
a8514e2
Fix SASS linting
Heenawter Sep 11, 2024
0f6d3a6
Fix stub types
Heenawter Sep 11, 2024
641bc89
Remove `import type`
Heenawter Sep 11, 2024
12ed334
Update `tsconfig`
Heenawter Sep 11, 2024
156fcf2
Fix control panel test
Heenawter Sep 11, 2024
0fd22e7
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Sep 11, 2024
7fc7df7
Fix more imports + types
Heenawter Sep 11, 2024
e0694ab
Merge branch 'embeddableRebuild_final-controls-cleanup_2024-09-03' of…
Heenawter Sep 11, 2024
2238540
Fix Discover example
Heenawter Sep 11, 2024
a337f11
Even more cleanup
Heenawter Sep 11, 2024
bbfcdf1
Add action type exports
Heenawter Sep 11, 2024
3640f0c
Even more type fixes - it never ends!
Heenawter Sep 11, 2024
e51ca08
Remove Storybook alias
Heenawter Sep 11, 2024
eb2517a
Remove `controls` storybook from build and upload step
Heenawter Sep 11, 2024
dbc461e
Re-add `editorConfig`
Heenawter Sep 11, 2024
69ed309
Final (?) type fixes
Heenawter Sep 12, 2024
6c714c8
Merge branch 'main' into embeddableRebuild_final-controls-cleanup_202…
Heenawter Sep 12, 2024
3917c17
Remove `ErrorEmbeddable` tests
Heenawter Sep 12, 2024
62c217c
Merge branch 'main' into embeddableRebuild_final-controls-cleanup_202…
Heenawter Sep 16, 2024
2084639
Merge branch 'main' into embeddableRebuild_final-controls-cleanup_202…
Heenawter Sep 16, 2024
b8ed89b
Merge branch 'main' into embeddableRebuild_final-controls-cleanup_202…
Heenawter Sep 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix telemetry types
  • Loading branch information
Heenawter committed Sep 10, 2024
commit 651fbc88879ae5aade6dd0ca6c10df5cf1d8b98d
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

import { PersistableStateService } from '@kbn/kibana-utils-plugin/common';
import { set } from '@kbn/safer-lodash-set';
import { SerializableRecord } from '@kbn/utility-types';
import {
ControlGroupRuntimeState,
ControlGroupSerializedState,
Expand Down Expand Up @@ -109,9 +108,10 @@ const reportControlTypes = (
return controlTypeStats;
};

export const controlGroupTelemetry: PersistableStateService<
SerializableRecord & ControlGroupSerializedState
>['telemetry'] = (state, stats): ControlGroupTelemetry => {
export const controlGroupTelemetry: PersistableStateService['telemetry'] = (
state,
stats
): ControlGroupTelemetry => {
const controlGroupStats = initializeControlGroupTelemetry(stats);
const controlGroupState = {
...getDefaultControlGroupState(),
Expand Down