-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Cell actions extension #190754
Merged
davismcphee
merged 21 commits into
elastic:main
from
davismcphee:discover-cell-actions-extension
Sep 11, 2024
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
6d929e7
Initial cell actions extension implementation
davismcphee 1cd3791
Improve use_cell_actions hook
davismcphee ffd46ca
Support passing params to cell actions
davismcphee ddac792
Rename use_cell_actions to use_additional_cell_actions
davismcphee d5d8be5
Update ID generation
davismcphee 4eb4538
Remove orig file
davismcphee b16eccd
Add cell actions embeddable support and Jest tests
davismcphee ea864ff
Fix Jest tests
davismcphee e4f03e4
Add createDataSource util
davismcphee 6c4a524
Add workaround for security cell actions
davismcphee dcffd95
Add Jest tests
davismcphee 90b11bf
Add functional tests
davismcphee f41ba76
Remove test cell action definitions
davismcphee 00a5d44
Move DISCOVER_CELL_ACTIONS_TRIGGER definition
davismcphee bd6a959
Merge branch 'main' into discover-cell-actions-extension
davismcphee 8558261
Update Disover plugin imports to try to address bundle size
davismcphee 3e6e750
Fix file license headers
davismcphee 194a43b
Merge branch 'main' into discover-cell-actions-extension
davismcphee 2d66307
Add surrounding docs support for cell actions extension
davismcphee cc68fec
Merge branch 'main' into discover-cell-actions-extension
davismcphee fc50e51
Fix context tests
davismcphee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add workaround for security cell actions
- Loading branch information
commit 6c4a524fc7809c50ed6206f7bfe6bbdce3251212
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elastic/security-threat-hunting-investigations I wanted to build this extension point on top of
kbn-cell-actions
since Unified Data Table already supports it, rather than introducing an alternative approach. Unfortunately this conflicts with the saved search embeddable cell action overrides currently active within the Security Solution UI.So I needed a way to disable the cell actions extension point when it would conflict with the overrides and couldn't figure out another way other than this. I'm open to ideas for a cleaner approach, but my thinking is that this won't be needed eventually anyway since ideally we'll migrate the current Security actions to a context aware Discover profile instead.