[Dashboard] Compressed Styles for Controls #190636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rshen91
changed the title
rshen91
added
the
Project:Dashboard Usability
rshen91
added
release_note:skip
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Heenawter
reviewed
Aug 27, 2024
src/plugins/controls/public/react_controls/control_group/components/control_group_editor.tsx
Outdated
Show resolved
Hide resolved
rshen91
added
release_note:enhancement
and removed
release_note:skip
nreese
reviewed
Aug 27, 2024
src/plugins/controls/public/control_group/component/control_frame_component.tsx
Show resolved
Hide resolved
Heenawter
reviewed
Aug 29, 2024
...s/dashboard/public/dashboard_app/top_nav/controls_toolbar_button/controls_toolbar_button.tsx
Outdated
Show resolved
Hide resolved
src/plugins/controls/public/range_slider/components/range_slider_editor_options.tsx
Outdated
Show resolved
Hide resolved
|
Main now uses react embeddable control group and we are activity working on removing the legacy control group. Changes to legacy control group should be discarded as they are not needed. |
Heenawter
reviewed
Sep 3, 2024
src/plugins/controls/public/control_group/component/control_frame_component.tsx
Show resolved
Hide resolved
andreadelrio
approved these changes
Sep 3, 2024
Heenawter
approved these changes
Sep 3, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @rshen91 |
logeekal
added a commit
that referenced
this pull request
Sep 9, 2024
…ols on Alerts Page. (#192094) ## Summary As stated in #192092 , the labels of filter controls were mis-aligned. This was due to some changes in EUI were conflicting with our custom styling. This PR removes the custom styling. ### Before  ### Issues with Error state It looks like recent PR #190636 on 03-Sept made the controls compact but the error state was left out. This PR fixes that. I would request @elastic/kibana-presentation team to review it once. <img width="1920" alt="grafik" src="https://github.com/user-attachments/assets/4025c79f-2602-4221-a136-436b6759096f"> ### After Below video shows fixes in success, loading and error states. @elastic/response-ops team, Could you please check in other areas as well where these filters are used. Thanks. https://github.com/user-attachments/assets/7e0f6035-171c-4a4b-99c6-116ad577a019
1 task
gergoabraham
pushed a commit
to gergoabraham/kibana
that referenced
this pull request
Sep 13, 2024
…ols on Alerts Page. (elastic#192094) ## Summary As stated in elastic#192092 , the labels of filter controls were mis-aligned. This was due to some changes in EUI were conflicting with our custom styling. This PR removes the custom styling. ### Before  ### Issues with Error state It looks like recent PR elastic#190636 on 03-Sept made the controls compact but the error state was left out. This PR fixes that. I would request @elastic/kibana-presentation team to review it once. <img width="1920" alt="grafik" src="https://github.com/user-attachments/assets/4025c79f-2602-4221-a136-436b6759096f"> ### After Below video shows fixes in success, loading and error states. @elastic/response-ops team, Could you please check in other areas as well where these filters are used. Thanks. https://github.com/user-attachments/assets/7e0f6035-171c-4a4b-99c6-116ad577a019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #190355
This builds off @ryankeairns work in #189839 to have the compressed styles for controls
Applied to new controls in example apps:
Applied to existing dashboard controls: