Extract authorization logic and it's peripherals into packages

[eokoneyo]

Summary

This PR is a precursor to #189871, as part of the spaces improvement initiative there's a need to be able to share the user privilege assignment component between the roles experience and the new spaces experience to prevent duplication of business logic and cohesiveness in the privilege assignment experience.

The aforementioned PR extracts the required component into it's own package so it might be consumed as needed, this PR is particularly concerned with extracting business logic said UI component depends on that exists still within the security plugin. For context; the security plugin already depends on the spaces plugin, so having the spaces plugin in turn statically depend on the security plugin creates a cyclic dependency. That being said to complement the eventual state of said component so it might be imported elsewhere outside of the security plugin there's a need to extract further logic into standalone packages, so that the spaces plugin can consume this plugin without the afore mentioned cyclic dependency problem.

Visually;

Problem;

Proposal

¹

Footnotes

1. items marked in blue are the packages created in this PR, whilst the entire diagram is the proposed future state ↩

[eokoneyo]

Note for reviewers;

The @kbn/security-authorization-core package consolidates the server logic that existed within the security plugin, and the business logic that the UI depends on for role/privilege management; the reasoning behind this is to consolidate all role . privilege management logic in one specific location, and more so as noted above, this also helps facilitate extracting the UI for assigning privileges of a role, so it might be reused.

[eokoneyo]

/ci

[elasticmachine]

Pinging @elastic/kibana-security (Team:Security)

[eokoneyo]

@elasticmachine merge upstream

[kc13greiner]

Overall LGTM! Just one question below

[kc13greiner]

Question: Is this being used anywhere?

[SiddharthMantri]

Nit: If this is intended for a future change, we recommend not introducing a dependency where a package depends on a plugins exported types. Ideally, such a dependency would be moved to a common package from where it'd be imported in all places where it's used.

[eokoneyo]

Hey @kc13greiner thanks for pointing this out, the type was actually not in use. I've removed it, and @SiddharthMantri thanks for the guidance there's a chance I'd actually need the type in the follow PR to this one.

[SiddharthMantri]

LGTM!

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 42d4579

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
security	524	523	-1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/security-authorization-core	-	24	+24
@kbn/security-role-management-model	-	74	+74
total			+98

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
security	589.4KB	589.4KB	+4.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
@kbn/security-authorization-core	-	7	+7
security	1	0	-1
total			+6

Unknown metric groups

API count

id	before	after	diff
@kbn/security-authorization-core	-	25	+25
@kbn/security-role-management-model	-	75	+75
total			+100

References to deprecated APIs

id	before	after	diff
@kbn/security-authorization-core	-	30	+30
@kbn/security-role-management-model	-	3	+3
security	53	22	-31
total			+2

History

• 💚 Build #228246 succeeded 47218a6
• 💚 Build #226994 succeeded 2100272
• 💛 Build #226724 was flaky 1d9ea5c
• 💔 Build #226677 failed 45d35dd
• 💔 Build #226363 failed 64cc29d
• 💔 Build #226226 failed 1b93a04

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @eokoneyo

[kc13greiner]

Thanks for the updates - LGTM!