Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flaky on mki] Increase timeout for kibanaReportCompletion, add delay between report checks #184508

Merged
merged 3 commits into from
Jun 2, 2024

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented May 30, 2024

Summary

Increase kibanaReportCompletion to 5m: this should help with recent failures like

Reporting Generate CSV from SearchSource validation Searches a large amount of data, stops at Max Size Reached
https://buildkite.com/elastic/appex-qa-serverless-kibana-ftr-tests/builds/1827

A report might take longer time to complete if the report is started when nodes are migrating slack

Also, add a delay between checks if the report is ready. Now we're hammering the server <1s, but I thought it wouldn't hurt adding a bit of delay and it might help with occasional "The instance rejected the connection." errors in those reporting tests.

@Dosant Dosant added the release_note:skip Skip the PR/issue when compiling release notes label May 30, 2024
@Dosant Dosant requested a review from a team as a code owner May 30, 2024 12:07
@Dosant Dosant requested a review from a team as a code owner May 31, 2024 14:25
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code, LGTM

I especially like the delay between polls to the download endpoint. We could consider doing the same for the stateful test services, but it not urgent or worth holding up this PR.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit 2570872 into elastic:main Jun 2, 2024
17 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Jun 2, 2024
Dosant added a commit that referenced this pull request Jun 10, 2024
## Summary

Follow up #184508

Increase kibanaReportCompletion to 10m: this should help with recent
failures like
> Reporting Generate CSV from SearchSource validation Searches a large
amount of data, stops at Max Size Reached

https://buildkite.com/elastic/appex-qa-serverless-kibana-ftr-tests/builds/1827

A report might take longer time to complete if the report is started
when nodes are migrating
[slack](https://elastic.slack.com/archives/C0574PUV998/p1717063959120689?thread_ts=1717018651.895229&cid=C0574PUV998)



Also see
#160329 (comment)
@Dosant Dosant self-assigned this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants