-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flaky on mki] Increase timeout for kibanaReportCompletion, add delay between report checks #184508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the code, LGTM
I especially like the delay between polls to the download endpoint. We could consider doing the same for the stateful test services, but it not urgent or worth holding up this PR.
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
## Summary Follow up #184508 Increase kibanaReportCompletion to 10m: this should help with recent failures like > Reporting Generate CSV from SearchSource validation Searches a large amount of data, stops at Max Size Reached https://buildkite.com/elastic/appex-qa-serverless-kibana-ftr-tests/builds/1827 A report might take longer time to complete if the report is started when nodes are migrating [slack](https://elastic.slack.com/archives/C0574PUV998/p1717063959120689?thread_ts=1717018651.895229&cid=C0574PUV998) Also see #160329 (comment)
Summary
Increase kibanaReportCompletion to 5m: this should help with recent failures like
A report might take longer time to complete if the report is started when nodes are migrating slack
Also, add a delay between checks if the report is ready. Now we're hammering the server <1s, but I thought it wouldn't hurt adding a bit of delay and it might help with occasional "The instance rejected the connection." errors in those reporting tests.