Add context to ELB-cleanup error messages #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
force-pushed
the
fons/improve-lb-delete-errors
branch
from
45c5640
to
764f810
Compare
marccarre
approved these changes
Jul 22, 2019
2opremio
force-pushed
the
fons/improve-lb-delete-errors
branch
from
764f810
to
5d60458
Compare
2opremio
force-pushed
the
fons/improve-lb-delete-errors
branch
from
5d60458
to
c3b158d
Compare
marccarre
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1042 by adding more context to errors and implicitly requiring to have Service list/delete permissions when deleting a cluster (otherwise we can end up with clusters deleted half-way).