Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

Keybase - Refactor into icon group template #1963

Merged
merged 2 commits into from
Jul 2, 2015
Merged

Keybase - Refactor into icon group template #1963

merged 2 commits into from
Jul 2, 2015

Conversation

altern8tif
Copy link
Contributor

Fixes #1864

@altern8tif
Copy link
Contributor Author

However, clicking the title brings it back to the search results page instead of the relevant keybase profile.

Is there a way to use the sourceUrl meta property instead of manually having to reference it in code?

@moollaza moollaza changed the title Keybase – Refactor into icon group template Keybase - Refactor into icon group template Jun 29, 2015
@moollaza moollaza self-assigned this Jun 29, 2015
@moollaza
Copy link
Member

@altern8tif if you specify a url property in your normalize it will server as the href for the title link -- I think that solves your problem?

@altern8tif
Copy link
Contributor Author

@moollaza Thanks! That addresses the issue...

@moollaza
Copy link
Member

moollaza commented Jul 2, 2015

LGTM 👍

moollaza added a commit that referenced this pull request Jul 2, 2015
@moollaza
Merge pull request #1963 from altern8tif/spice_keybase
dba9f3d 
Keybase - Refactor into icon group template
@moollaza moollaza merged commit dba9f3d into duckduckgo:master Jul 2, 2015
@moollaza
Copy link
Member

moollaza commented Jul 2, 2015

@altern8tif thanks again 😄

@altern8tif altern8tif deleted the spice_keybase branch July 10, 2015 20:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@moollaza moollaza

Labels
Design Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@altern8tif @moollaza