Various additions #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 6, 2020 12:32
Instead of defining derivation via a given, make it explicit via `macroR` and `macroW` defs. This also copies upickle's original behaviour. Also remove wildcard imports from the compiletime and deriving packages.
jodersky
commented
Aug 6, 2020
jodersky
commented
Aug 6, 2020
Comment on lines
+6
to
+12
| def serializeDefaults: Boolean = false | ||
|
|
||
| def objectAttributeKeyReadMap(s: CharSequence): CharSequence = s | ||
| def objectAttributeKeyWriteMap(s: CharSequence): CharSequence = s | ||
|
|
||
| def objectTypeKeyReadMap(s: CharSequence): CharSequence = s | ||
| def objectTypeKeyWriteMap(s: CharSequence): CharSequence = s |
anatoliykmetyuk
approved these changes
Aug 10, 2020
| end getDefaultParmasImpl | ||
|
|
||
| inline def summonAll[T <: Tuple]: List[_] = | ||
| inline def summonList[T <: Tuple]: List[_] = |
There was a problem hiding this comment.
summonAll was defined here temporarily while we didn't have one in Dotty. Now we do. Can we completely remove summonAll and summonList from here and use the Dotty implementation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently WIP, these changes aim to bring the upickle community build up to feature parity with scala 2.
Some notable changes:
macroR,macroWandmacroRWupickle.implicits.keyannotationMany tests still fail and/or need to be reactivated