Pin tool and package versions to reduce build non-determinism #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeharder
approved these changes
Oct 24, 2017
| <PropertyGroup> | ||
| <VersionPrefix>2.1.0</VersionPrefix> | ||
| <VersionSuffix>preview1</VersionSuffix> | ||
| <PackageVersion Condition="'$(IsFinalBuild)' == 'true' AND '$(VersionSuffix)' == 'rtm' ">$(VersionPrefix)</PackageVersion> |
There was a problem hiding this comment.
Wouldn't KoreBuild normally take care of this? Are we going to need this logic in every repo? I feel like doing this logic per-repo is going to lead to something being missed and us making bad versions at some point.
There was a problem hiding this comment.
Yes, this will be in each repo. Although currently the Universe build takes care of normalizing versions for "final" builds, the addition of aspnet/templating to aspnet/Universe, PCP and source-build efforts required that we also push this logic down into individual repos.
ryanbrandenburg
approved these changes
Oct 24, 2017
natemcmaster
force-pushed
the
namc/determinism
branch
from
446ec43
to
5df2c33
Compare
natemcmaster
changed the title
45 tasks
pakrym
pushed a commit
that referenced
this pull request
Apr 20, 2018
natemcmaster
pushed a commit
that referenced
this pull request
Nov 6, 2018
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of aspnet/KoreBuild#239 and aspnet/Universe#575
This change removes some sources of non-determinism in our build. Package versions are hard-coded and do not float, and the build tools version is committed to source.
In addition, it removes the need for devs to run
build.cmd /t:Pinbefore opening VS.