Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function get_batch_scores to compute sub-docs' bm25 score #6

Merged
merged 1 commit into from
May 1, 2020

Conversation

nlp4whp
Copy link
Contributor

@nlp4whp nlp4whp commented Apr 26, 2020

Hi,
I add a new function named get_batch_scores to compute score between query and a subset of all corpus;
because get_scores is a little bit slow when user pass huge number of corpus into bm25 model;
For instance, my corpus includes about 40w docs, and get_scores will cost more than 1 second,

@dorianbrown
Copy link
Owner

Thanks for the merge request, looks like useful functionality and fits nicely with the rest. This will help with performance, but it might be worthwhile to investigate making it perform faster on larger corpuses, which should be feasible.

@dorianbrown dorianbrown merged commit d5987d3 into dorianbrown:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants